CIWEMB-213: Add field to link recur contribution with payment scheme #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the payment_scheme_id custom field to the payment_plan_extra_attributes custom group, so it could be used to link a payment scheme to a recurring contribution.
erawat
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding
payment_scheme_idcustom field to "Payment Plan extra attributes" custom group, so we can use it to link a recurring contribution to a payment scheme.Technical Details
The initial plan was to create new entity with the following:
But I found that we already have a custom group called "Payment Plan extra attributes" on the payment plan, so I found that it is easier and probably better to just add new field to it instead of creating new entity.
Also in general having API v3 support is not that important, and that we can just use API v4, which allows us to update or retrieve the value of this field using its name (unlike V3 that requires the custom field id, which results in more complicated queries), thus saving us from creating new API: