Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIWEMB-372: Update the payment scheme form #481

Merged

Conversation

ahed-compucorp
Copy link
Contributor

Overview

This PR updates the payment scheme fields :

  • The admin title field is not required anymore.
  • The Admin Description field text becomes Description.
  • The Public Description field is required.
  • The permission text becomes Permission.

and updated the max-length attribute of each text field to follow the specification file i.e. the user cannot type more text than the specific text length.

Before

Screenshot from 2023-07-18 18-33-28

After

Screenshot from 2023-07-18 17-09-21

Technical Details

First, I've updated both the scheme and form files.
Second, I've run the command:

./civix-22.07.1/bin/civix  generate:entity-boilerplate

to update the DAO and SQL files. Please note, I used the previous version of civix, because the current
version requires upgrading the extension before running any command.

@ahed-compucorp ahed-compucorp force-pushed the CIWEMB-372-update-payment-scheme-form branch from 1e780f7 to 8cc466c Compare July 18, 2023 15:51
@ahed-compucorp ahed-compucorp force-pushed the CIWEMB-372-update-payment-scheme-form branch from 8cc466c to 215c80b Compare July 18, 2023 16:41
@ahed-compucorp ahed-compucorp self-assigned this Jul 18, 2023
@ahed-compucorp ahed-compucorp added the bug Something isn't working label Jul 18, 2023
I've run the command:
```
./civix-22.07.1/bin/civix  generate:entity-boilerplate
```

Please note, I used previous version of civix, because the current
version requires upgrading the extension before running any command.
@ahed-compucorp ahed-compucorp force-pushed the CIWEMB-372-update-payment-scheme-form branch from d32c80f to d93b5ba Compare July 19, 2023 14:24
@ahed-compucorp ahed-compucorp merged commit 8ce9cf6 into CIWEMB-84-workstream Jul 19, 2023
2 checks passed
@ahed-compucorp ahed-compucorp deleted the CIWEMB-372-update-payment-scheme-form branch July 19, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants