Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIWEMB-476: Usability improvements to the "manage instalments" forms #498

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

omarabuhussein
Copy link
Member

@omarabuhussein omarabuhussein commented Sep 26, 2023

Before

Issue 1

When trying to add a line item through the manage instalments screen, and after clicking "Apply", the "Apply" button will remain enabled until the form is fully submitted, which might lead to users clicking on it twice or more by mistake, which may result in multiple submissions.

1before

Issue 2

When trying to add a line item through the manage instalments screen or if you are using the "Switch membership type" option, and if you select a "one-off payment" option and entered a non numeric value, then the payment form will disappear and nothing will happen:

2before

After

Issue 1

The "Apply" button will be disabled after the user clicks on, and so preventing multi submissions:
1after

Issue 2

Entering non numeric value in the amount field will show the validation error properly.
2after

@omarabuhussein omarabuhussein changed the title Ciwemb 476 fix double submit CIWEMB-476: Usability improvements to the "manage instalments" forms Sep 26, 2023
@omarabuhussein omarabuhussein merged commit cc24ce1 into CIWEMB-84-workstream Sep 26, 2023
2 checks passed
@omarabuhussein omarabuhussein deleted the CIWEMB-476-fix-double-submit branch September 26, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants