COMCL-410: Hide unnecessary fields for non active payment plans that are linked to a payment scheme #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarabuhussein
changed the title
…are linked to a payment scheme
omarabuhussein
force-pushed
the
COMCL-410-show-scheme-foractive
branch
from
ebaf5f6
to
5ab4dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this PR: #473 we hide various fields that are irrelevant for payment plans that are linked to payment schemes, but this was only done for active payment plans, so it would be better if we also hide them for non active payment plans as well.
Before
The following fields appear on inactive payment plans that are linked to payment schemes:
beff11.mp4
After
The mentioned fields no longer appear on inactive payment plans that are linked to payment schemes:
after111.mp4
But there is still a difference, the "Future payment scheme" table is hidden on inactive payment plans:
given inactive payment plans won't renewal, so there are no future instalments and so there is no point in showing this table.