Fix wrong shape on propTypes.tapAction (microsoft#2253)

* Fix wrong shape on propTypes.tapAction * Update PR number * Should pass language * Pass language and rename to aria-label
compulim · Aug 1, 2019 · 6169f64 · 6169f64
1 parent 95e4ecd
commit 6169f64
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -59,6 +59,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 -  Fix [#2193](https://github.com/microsoft/BotFramework-WebChat/issues/2193). Fix Adaptive Card/attachments do not get read by Narrator, by [@corinagum](https://github.com/corinagum) in PR [#2226](https://github.com/microsoft/BotFramework-WebChat/pull/2226)
 -  Fix [#2150](https://github.com/microsoft/BotFramework-WebChat/issues/2193). Fix timestamps read by Narrator, by [@corinagum](https://github.com/corinagum) in PR [#2226](https://github.com/microsoft/BotFramework-WebChat/pull/2226)
 -  Fix [#2240](https://github.com/microsoft/BotFramework-WebChat/issues/2240). Fix microphone button should be re-enabled after error, by [@compulim](https://github.com/compulim) in PR [#2241](https://github.com/microsoft/BotFramework-WebChat/pull/2241)
+-  Fix [#2250](https://github.com/microsoft/BotFramework-WebChat/issues/2250). Fix React warnings related prop types, by [@compulim](https://github.com/compulim) in PR [#2253](https://github.com/microsoft/BotFramework-WebChat/pull/2253)
 
 ### Added
 

diff --git a/packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js b/packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js
@@ -193,7 +193,10 @@ AdaptiveCardRenderer.propTypes = {
   styleSet: PropTypes.shape({
     adaptiveCardRenderer: PropTypes.any.isRequired
   }).isRequired,
-  tapAction: PropTypes.func
+  tapAction: PropTypes.shape({
+    type: PropTypes.string.isRequired,
+    value: PropTypes.string
+  })
 };
 
 AdaptiveCardRenderer.defaultProps = {

diff --git a/packages/component/src/Attachment/TypingActivity.js b/packages/component/src/Attachment/TypingActivity.js
@@ -7,7 +7,7 @@ import TypingAnimation from './Assets/TypingAnimation';
 
 const TypingActivity = ({ language, styleSet }) => (
   <div className={styleSet.typingActivity}>
-    <TypingAnimation ariaLabel={localize('TypingIndicator', language)} />
+    <TypingAnimation aria-label={localize('TypingIndicator', language)} />
   </div>
 );
 
@@ -18,4 +18,4 @@ TypingActivity.propTypes = {
   }).isRequired
 };
 
-export default connectToWebChat(({ styleSet }) => ({ styleSet }))(TypingActivity);
+export default connectToWebChat(({ language, styleSet }) => ({ language, styleSet }))(TypingActivity);
diff --git a/packages/component/src/ErrorBox.js b/packages/component/src/ErrorBox.js
@@ -25,4 +25,4 @@ ErrorBox.propTypes = {
   }).isRequired
 };
 
-export default connectToWebChat(({ styleSet }) => ({ styleSet }))(ErrorBox);
+export default connectToWebChat(({ language, styleSet }) => ({ language, styleSet }))(ErrorBox);