Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
  • Loading branch information
compulim and corinagum committed Jul 23, 2019
1 parent 194ce85 commit a05ad1c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added

- Added bubble nub and style options, by [@compulim](https://github.com/compulim), in PR [#2137](https://github.com/microsoft/BotFramework-WebChat/pull/2137)
- Make thumbnails for uploading GIF/JPEG/PNG and store it in `channelData.attachmentThumbnails`, by [@compulim](https://github.com/compulim), in PR [#2206](https://github.com/microsoft/BotFramework-WebChat/pull/2206), requires modern browsers with following features:
- Make thumbnails when uploading GIF/JPEG/PNG and store it in `channelData.attachmentThumbnails`, by [@compulim](https://github.com/compulim), in PR [#2206](https://github.com/microsoft/BotFramework-WebChat/pull/2206), requires modern browsers with following features:
- [Web Workers API](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API)
- [`createImageBitmap`](https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/createImageBitmap)
- [`MessageChannel`](https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel)/[`MessagePort`](https://developer.mozilla.org/en-US/docs/Web/API/MessagePort)
Expand Down
2 changes: 1 addition & 1 deletion __tests__/setup/pageObjects/sendFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default async function sendFile(driver, filename, { waitForSend = true }
const uploadButton = await getUploadButton(driver);
const isUnderDocker = !!(await driver.getCapabilities()).get('webdriver.remote.sessionid');

// The send file function is asynchronous, it don't send immediate until thumbnails are generated.
// The send file function is asynchronous, it doesn't send immediately until thumbnails are generated.
// We will save the numActivities, anticipate for numActivities + 1, then wait until everything is sent
const numActivities = (await getActivityElements(driver)).length;

Expand Down

0 comments on commit a05ad1c

Please sign in to comment.