Fix ESLint and rename to bypass

compulim · Oct 4, 2019 · bd5f2b5 · bd5f2b5
1 parent 26aa5c2
commit bd5f2b5
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/packages/component/src/BasicTranscript.js b/packages/component/src/BasicTranscript.js
@@ -10,9 +10,9 @@ import ScrollToEndButton from './Activity/ScrollToEndButton';
 import SpeakActivity from './Activity/Speak';
 
 import {
-  speechSynthesis as noopSpeechSynthesis,
-  SpeechSynthesisUtterance as NoopSpeechSynthesisUtterance
-} from './Speech/noopSpeechSynthesisPonyfill';
+  speechSynthesis as bypassSpeechSynthesis,
+  SpeechSynthesisUtterance as BypassSpeechSynthesisUtterance
+} from './Speech/BypassSpeechSynthesisPonyfill';
 
 const ROOT_CSS = css({
   overflow: 'hidden',
@@ -91,8 +91,8 @@ const BasicTranscript = ({
       <ScrollToBottomPanel className={PANEL_CSS + ''}>
         <div className={FILLER_CSS} />
         <SayComposer
-          speechSynthesis={speechSynthesis || noopSpeechSynthesis}
-          speechSynthesisUtterance={SpeechSynthesisUtterance || NoopSpeechSynthesisUtterance}
+          speechSynthesis={speechSynthesis || bypassSpeechSynthesis}
+          speechSynthesisUtterance={SpeechSynthesisUtterance || BypassSpeechSynthesisUtterance}
         >
           <ul
             aria-atomic="false"

diff --git a/...src/Speech/noopSpeechSynthesisPonyfill.js → ...c/Speech/BypassSpeechSynthesisPonyfill.js b/...src/Speech/noopSpeechSynthesisPonyfill.js → ...c/Speech/BypassSpeechSynthesisPonyfill.js
@@ -1,3 +1,10 @@
+// Since this is a bypass, we will relax some ESLint rules
+
+/* eslint class-methods-use-this: "off" */
+/* eslint getter-return: "off" */
+/* eslint max-classes-per-file: ["error", 4] */
+/* eslint no-empty-function: "off" */
+
 import EventTarget, { defineEventAttribute } from '../external/event-target-shim';
 
 class SpeechSynthesisEvent {

diff --git a/packages/component/src/external/event-target-shim.js b/packages/component/src/external/event-target-shim.js