Fix version number to burn correctly under Ubuntu (microsoft#2525)

* Use lowercase for npm_package_version * Lowercase npm_package_version * Add entry
compulim · Oct 31, 2019 · dd80827 · dd80827
1 parent 11332a8
commit dd80827
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -103,6 +103,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 -  Fixes [#2518](https://github.com/microsoft/BotFramework-WebChat/issues/2518). Synthesis of bot activities with input hint expecting, should be interruptible, by [@compulim](https://github.com/compulim) in PR [#2520](https://github.com/microsoft/BotFramework-WebChat/pull/2520)
 -  Fixes [#2519](https://github.com/microsoft/BotFramework-WebChat/issues/2519). On Safari, microphone should turn on after synthesis of bot activities with input hint expecting, by [@compulim](https://github.com/compulim) in PR [#2520](https://github.com/microsoft/BotFramework-WebChat/pull/2520)
 -  Fixes [#2521](https://github.com/microsoft/BotFramework-WebChat/issues/2521). `webchat-es5.js` should not contains non-ES5 code and must be loadable by IE11, by [@compulim](https://github.com/compulim) in PR [#2522](https://github.com/microsoft/BotFramework-WebChat/pull/2522)
+-  Fixes [#2524](https://github.com/microsoft/BotFramework-WebChat/issues/2524). Version was not burnt into source code correctly, by [@compulim](https://github.com/compulim) in PR [#2525](https://github.com/microsoft/BotFramework-WebChat/pull/2525)
 
 ### Added
 

diff --git a/packages/bundle/.babelrc b/packages/bundle/.babelrc
@@ -13,7 +13,7 @@
     [
       "transform-inline-environment-variables", {
         "include": [
-          "NPM_PACKAGE_VERSION"
+          "npm_package_version"
         ]
       }
     ]

diff --git a/packages/bundle/src/addVersion.js b/packages/bundle/src/addVersion.js
@@ -21,7 +21,7 @@ function setMetaTag(name, content) {
 
 export default function addVersion(variant) {
   setMetaTag('botframework-webchat:bundle:variant', variant);
-  setMetaTag('botframework-webchat:bundle:version', process.env.NPM_PACKAGE_VERSION);
+  setMetaTag('botframework-webchat:bundle:version', process.env.npm_package_version);
   setMetaTag('botframework-webchat:core:version', coreVersion);
   setMetaTag('botframework-webchat:ui:version', componentVersion);
 }
diff --git a/packages/component/.babelrc b/packages/component/.babelrc
@@ -25,7 +25,7 @@
     [
       "transform-inline-environment-variables", {
         "include": [
-          "NPM_PACKAGE_VERSION"
+          "npm_package_version"
         ]
       }
     ]

diff --git a/packages/component/src/index.tsx b/packages/component/src/index.tsx
@@ -36,7 +36,7 @@ import createStyleSet from './Styles/createStyleSet';
 import defaultStyleOptions from './Styles/defaultStyleOptions';
 import getTabIndex from './Utils/TypeFocusSink/getTabIndex';
 
-const version = process.env.NPM_PACKAGE_VERSION;
+const version = process.env.npm_package_version;
 
 const Components = {
   Composer,

diff --git a/packages/core/.babelrc b/packages/core/.babelrc
@@ -12,7 +12,7 @@
     [
       "transform-inline-environment-variables", {
         "include": [
-          "NPM_PACKAGE_VERSION"
+          "npm_package_version"
         ]
       }
     ]

diff --git a/packages/core/src/index.js b/packages/core/src/index.js
@@ -29,7 +29,7 @@ import * as ActivityClientState from './constants/ActivityClientState';
 import * as DictateState from './constants/DictateState';
 
 const Constants = { ActivityClientState, DictateState };
-const version = process.env.NPM_PACKAGE_VERSION;
+const version = process.env.npm_package_version;
 
 export {
   clearSuggestedActions,