Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize scaffold #25

Merged
merged 15 commits into from Feb 28, 2022
Merged

Modernize scaffold #25

merged 15 commits into from Feb 28, 2022

Conversation

compulim
Copy link
Owner

@compulim compulim commented Feb 28, 2022

Summary

Bump deps, update scaffold to modernize tests, some cosmetics changes.

Changelog

Changed

Design considerations

We want more realistic end-to-end tests. Thus, we are using isolated Docker containers to test every combination of Node.js, NPM, and resolvers.

  • Node.js
    • 12, 14, 16
  • NPM
    • Default (from current install of Node.js)
    • Latest (run npm install -g npm)
  • Resolvers
    • Node.js
      • CommonJS (require('p-defer-es5))
      • ES Module (import 'p-defer-es5')
      • Global object (globalThis.createDeferred)
    • Bundlers (no /node_modules/)
      • ESBuild
      • Rollup
      • Webpack 4 via CommonJS
      • Webpack 4 via ES Module
      • Webpack 5 via CommonJS
      • Webpack 5 via ES Module

Specific changes

  • Bumped all dependencies
  • Moved terser from production dependencies to development dependencies
    • It is only used in npm run prepublishOnly, which dependents will not run this script
  • Segregated end-to-end tests into their own Dockerfile
  • Added pull_request_template.md
  • Updated scripts/esbuild.mjs for breaking changes from read-pkg-up
  • Disabled CD pipeline for pull request

Reminders

  • I have updated CHANGELOG.md
  • I have added tests for new code
  • I have updated documentations

@compulim compulim marked this pull request as ready for review February 28, 2022 16:00
@compulim compulim merged commit 5943a70 into master Feb 28, 2022
@compulim compulim deleted the feat-modernize branch February 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant