Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audiostart/soundstart event, abort/stop function, and continuous mode #33

Merged
merged 28 commits into from
Jul 30, 2019
Merged

Add audiostart/soundstart event, abort/stop function, and continuous mode #33

merged 28 commits into from
Jul 30, 2019

Conversation

compulim
Copy link
Owner

@compulim compulim commented Jul 30, 2019 •
edited
Loading

Fix #23, fix #24, fix #25, fix #26, fix #29.

Background

This PR will bring much better parity between Cognitive Services and Web Speech API. Notably:

  • audiostart/audioend event
  • soundstart/soundend event
  • True abort and stop
  • Continuous mode

Changelog

Added

  • Fix #23 and #24, support audiostart/audioend/soundstart/soundend event, in PR #33
  • Fix #25 and #26, support true abort and stop function, in PR #33
  • Fix #29, support continuous mode, in PR #33
    • Quirks: in continuous mode, calling stop in-between recognizing and recognized will not emit final result event
  • New audioConfig option to override the default AudioConfig.fromDefaultMicrophoneInput, in PR #33

@compulim compulim changed the title Parity work Add audiostart/soundstart event, abort/stop function, and continuous mode Jul 30, 2019
@compulim compulim merged commit 7e76a43 into master Jul 30, 2019
@compulim compulim deleted the feat-more-events branch July 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@compulim