Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Web3Module vuex module. #48

Closed
thirtyaughtsix opened this issue Jul 26, 2019 · 3 comments
Closed

Create a Web3Module vuex module. #48

thirtyaughtsix opened this issue Jul 26, 2019 · 3 comments
Assignees

Comments

@thirtyaughtsix
Copy link
Contributor

Create a new Web3Module vuex module. We'll quarantine Web3 here and also encapsulate the protocol stuff here as well.

First things first, we need to include a Web3 into the project. It needs to be exactly version beta-37.

One thing to keep in mind (and it has relevance to the class/no-class discussion - and no I ain't talking about the Kardashians): something weird happens in certain contexts whereby the type of the VuexModule isn't what you expect it to be. Rather than being an instance of your fancy custom subclass of VuexModule it appeaers to be a decorated version of state. That means that most of your expectations about this.whatever are wrong.

The tl;dr is that we need to use external classes to encapsulate logic we want to externalize from methods in any VuexModule. This probably drives OO purists nuts. Good.

@thirtyaughtsix
Copy link
Contributor Author

thirtyaughtsix commented Jul 26, 2019

We need to come up with a way to configure this vuex module at "boot," like storing the contract addresses in a yaml or something. Someone needs to do a quick couple hour spike on figuring that out.

I mean we could hardcode that stuff but that's awfully ghetto.

@thirtyaughtsix
Copy link
Contributor Author

I'll just leave this here: https://yarnpkg.com/lang/en/docs/cli/add/

@thirtyaughtsix thirtyaughtsix self-assigned this Jul 29, 2019
@thirtyaughtsix
Copy link
Contributor Author

Gonna piggyback getter testing and preliminary metamask integration stuff in this same PR

thirtyaughtsix added a commit that referenced this issue Jul 30, 2019
… crap. Let's get this PR reviewed before committing to the pattern.
thirtyaughtsix added a commit that referenced this issue Jul 30, 2019
* WIP

* WIP

* Implements #48.  Renamed the 'datatrust' folder.  Cleaned up some other crap.  Let's get this PR reviewed before committing to the  pattern.

* Code review issues

* fix bad click handler bind syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant