Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Vue components #73

Closed
thirtyaughtsix opened this issue Aug 1, 2019 · 1 comment
Closed

Audit Vue components #73

thirtyaughtsix opened this issue Aug 1, 2019 · 1 comment
Labels

Comments

@thirtyaughtsix
Copy link
Contributor

thirtyaughtsix commented Aug 1, 2019

Identify all Vue components and Vuex modules that need a refactor:

We need to flag every class that needs to have methods pulled out into a separate pure function container class, basically just a module with funs.

So that's anything in a component that isn't a: Vue property, Vue data, Vue getter, Vue named event handler.

Put the list here in the convo of the issue.

References #67

@thirtyaughtsix thirtyaughtsix changed the title Refactor audit Vue component Refactor audit Vue components Aug 1, 2019
@thirtyaughtsix thirtyaughtsix changed the title Refactor audit Vue components Audit Vue components Aug 1, 2019
This was referenced Aug 1, 2019
@MelvinMallari
Copy link
Contributor

MelvinMallari commented Aug 2, 2019

  • FileLister.vue
    • list()
  • FileMetaData.vue
    • validateTitle()
    • onTitleChange()
  • FileUploader.vue
    • initializeDropzone()
    • upload()
    • renameFile()
    • fileAdded()
    • fileRemoved()
    • preprocessFileData()
    • uploadProgressed()
    • succeeded()
    • failed()
  • StartListingButton.vue
    • startListing()
  • FfaTag.vue
    • deleteTag()
  • FfaTagger.vue
    • addTags()
  • FlashMessage.vue
    • remove()
  • Navigation.vue
    • setPublicKey()
  • Status.vue
    • execute()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants