Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Vuex modules #76

Closed
thirtyaughtsix opened this issue Aug 1, 2019 · 1 comment
Closed

Refactor Vuex modules #76

thirtyaughtsix opened this issue Aug 1, 2019 · 1 comment
Assignees
Labels

Comments

@thirtyaughtsix
Copy link
Contributor

thirtyaughtsix commented Aug 1, 2019

Use the list from #74 and refactor each Vuex module. One component -> one PR.

New funs should be pure so they can be static. Let's create a new top level folder called @/functionModules. Component function modules probably belong in @/functionModules/components while Vuex modules probably belong in @/functionModules/vuexModules/.

Use the list from #73 and refactor each Vue component. One component -> one PR.

New funs should be pure so they can be static. Let's create a new top level folder called @/functionModules. Component function modules probably belong in @/functionModules/components while Vuex modules probably belong in @/functionModules/vuexModules/.

Don't forget to add specs!

@thirtyaughtsix
Copy link
Contributor Author

There are no funs to move in the Vuex modules so I am going to repurpose this to clean up the Vuex modules, basically remove the comment blocks from: FlashesModule, ListModule, UploadModule, 'VoteModule`

thirtyaughtsix added a commit that referenced this issue Aug 1, 2019
@thirtyaughtsix thirtyaughtsix self-assigned this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant