Python Wrapper for FHEcontext #11
Conversation
|
Build now functional on Linux but failing on Mac due to strange linker issues. Since none of us are developing on Mac, I'm going to just turn off the OSX build for time being. We can come back and fix this later. |
rbharath
changed the title
|
|
||
| def __init__(self, user=False): | ||
| self.user = user | ||
| def __init__(self, user=False): |
There was a problem hiding this comment.
I dislike mismatched types when doing flags like this. self.user will likely be some object whenever it is eventually assigned yes? (or is it a string or some other primitive?). Thus having either an object (has been assigned) or a bool (unassigned) mismatch.
if its an object eventually use None as the falsy.
There was a problem hiding this comment.
Good comment. I copy/pasted this code from a PyBind11 tutorial, but we should clean this up a bit. I'll add this onto the clean-up list for the repo.
This PR adds a Python wrapper for
FHEcontext. This turned out to be much harder than expected due to many linker issues. Python'sdistutilssupport for building C/C++ extensions is really kludgy in places and not super documented. Managed to get it working on my laptop, but lots of hardcoded paths.Marking WIP till travis passes.