Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify _mask indexing as NumPy-style indexing #12

Closed
JorisVincent opened this issue Mar 18, 2023 · 1 comment · Fixed by #101
Closed

Unify _mask indexing as NumPy-style indexing #12

JorisVincent opened this issue Mar 18, 2023 · 1 comment · Fixed by #101
Assignees
@JorisVincent
Labels
maintenance
Milestone
v1.0.0

Comments

@JorisVincent
Copy link
Contributor

0-based indexing, but allowing negative indexing counting from "the other side"
@JorisVincent JorisVincent added this to the v1.0.0 milestone Mar 18, 2023
@JorisVincent JorisVincent self-assigned this Mar 24, 2023
@JorisVincent
Copy link
Contributor Author

0-based indexing is difficult, since unmasked regions are given 0 value, i.e., False. Thus, the first masked region cannot have index 0.

@JorisVincent JorisVincent linked a pull request Aug 28, 2023 that will close this issue
Refactor target placement #101
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorisVincent JorisVincent

Labels
maintenance
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Refactor target placement computational-psychology/stimupy
1 participant
@JorisVincent