Refactor target placement #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to standardize logic of indicating elements of gratings etc. as targets, which is a big par of the `stimuli` Also allows for negative element indices, counting backwards from the highest element index Closes #12
actually places targets in stimulus-dict
This was
linked to
issues
Aug 28, 2023
|
One consideration: should |
LynnSchmittwilken
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Everything looks good, but there are some non-PR-related issues in the demos (see issue #102 ). Also not all style-checks pass because bare except statements are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more general-purpose functions
mask_targets()andplace_targets()which can be used to designate target "elements" (bars, rings, frames, etc.) from an existing mask.This has been integrated into
waves,pinwheels,ringsandwhites, and been used to addrings.circular_generalized()andbullseye.circular_generalized().This single-implementation of target placement has the advantage that it all works the same: first element is
1, target_indices can be negative (counting "backwards" from the last bar/ring/etc.).To implement this, some of the public-facing API has to change, as indicated by the fact that the
papershave to be updated. Thus, this technically constitutes a "breaking" change that would require a major version bump....