Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target positions in todorovic_benary figure #90

Closed
lpstb50 opened this issue Jun 7, 2023 · 0 comments
Closed

Target positions in todorovic_benary figure #90

lpstb50 opened this issue Jun 7, 2023 · 0 comments
Assignees
@JorisVincent
Labels
bug Something isn't working

Comments

@lpstb50
Copy link

lpstb50 commented Jun 7, 2023

Observed/expected behavior

This is not a technical bug, but I am reporting what I think might be a mistake (I may be wrong). The todorovic_benary1_2 function (in stimupy.papers.RHS2007) outputs a figure with gray triangles that seem to be the ones numbered 1 and 4 in Robinson et al. (2007). This is also the case for todorovic_benary3_4 function (this outputs No.2 and 3). According to Robinson et al. (2007), the four triangles are numbered 1 to 4 from the left so I think a todorovic_benary1_2 figure should have two leftmost triangles.

Apologies if I am wrong, and thank you so much for all your effort for this useful tool.
@lpstb50 lpstb50 added the bug Something isn't working label Jun 7, 2023
JorisVincent added a commit that referenced this issue Jul 15, 2023
@JorisVincent
fix(RHS2007): correct targets in Todorovic' Benary 1_2, 3_4
1cab2db 
Closes #90

1_2_3_4() was already correct.
Others now use that one as base
@JorisVincent JorisVincent mentioned this issue Jul 15, 2023
Merged
@JorisVincent JorisVincent self-assigned this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorisVincent JorisVincent

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JorisVincent @lpstb50