Bugfixes #121
Merged
Bugfixes #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pillow is complaining about `libraqm` not being installed. Previously, it was not complaining about this. This problem seems to be limited to asking for a writing direction -- without that, Pillow no longer complains
fix(text): remove text direction argument
Some configuration was causing errors
Previously, the targets in black were lumped together, as were the targets in white. Now, each target, in each of the two stimuli, has its own mask idx
Only mask of WE_dual changed
Use `components.draw_regions` to do the actual target drawing. Ensures consistency with other stimuli with targets
Previously, checkerboards could only draw a single target intensity, even if multiple targets are specified. For some stimuli however, I want to have two target checks, each with a different intensity value. Use components.draw_regions to do the actual target drawing. Ensures consistency with other stimuli with targets.
Fix(RHS2007): Individually mask each target in WE_Dual
fix(whites): enable specifying either 1, or multiple target indices
|
This should automatically release a patch version There are some other bugs I'd like to fix, mostly based around the |
LynnSchmittwilken
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components.texts.textargumentdirectiondeprecatedRHS2007.WE_Dualtarget maskstimuli.checkerboards,stimuli.whitesnow correctly deal with 1 vs. multiple target specifications