Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cornsweet edge intensity is now exactly as in intensity_edges #123

Merged
merged 1 commit into from Apr 23, 2024
Merged

fix: cornsweet edge intensity is now exactly as in intensity_edges #123

merged 1 commit into from Apr 23, 2024

Conversation

LynnSchmittwilken
Copy link
Contributor

@LynnSchmittwilken LynnSchmittwilken commented Apr 22, 2024 •
edited by JorisVincent

Closes #122

@JorisVincent JorisVincent changed the title fix: cornsweet edge intensity is now exactly as in intensity_edges; c… fix: cornsweet edge intensity is now exactly as in intensity_edges Apr 23, 2024
JorisVincent
JorisVincent approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@JorisVincent JorisVincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorisVincent JorisVincent added the bug Something isn't working label Apr 23, 2024
@JorisVincent JorisVincent merged commit 9e8bbbb into main Apr 23, 2024
16 of 17 checks passed
@JorisVincent JorisVincent deleted the bugfix_cornsweet_edge branch April 23, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorisVincent JorisVincent JorisVincent approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intensitiy of Cornsweet edges is not exactly as defined in "intensity_edges"
2 participants
@LynnSchmittwilken @JorisVincent