Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing on a cell that returns no output normally #81

Closed
psychemedia opened this issue Jan 12, 2018 · 2 comments
Closed

Failing on a cell that returns no output normally #81

psychemedia opened this issue Jan 12, 2018 · 2 comments

Comments

@psychemedia
Copy link

psychemedia commented Jan 12, 2018

I have a notebook in which a code cell is used to run a shell command that, if all goes well, does not return anything. If the shell command breaks, an error message is returned and displayed as code cell output.

This error does not seem to result in a failed test.

To test this, I created a notebook with 3 code cells, print('test') in each, ran the notebook, cleared the output of the second code cell and then ran a test. It passed whereas I would have expected it to fail in the sense of cell 2 generating an output where there was none originally.

@takluyver
Copy link
Member

Thanks - #82 should fix it.

@takluyver
Copy link
Member

Released nbval 0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants