Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty data structures, handle non-numerics consistently, and typed-array support. #2

Merged
merged 7 commits into from Jul 22, 2015
Merged

Empty data structures, handle non-numerics consistently, and typed-array support. #2

merged 7 commits into from Jul 22, 2015

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jun 25, 2015

  • Return an empty data structure, rather than null.
  • Handle non-numeric values consistently => return NaN.
  • Moved typed-array support to separate file.

@Planeshifter
Copy link
Contributor

LGTM.

@kgryte
Copy link
Contributor Author

kgryte commented Jul 16, 2015

@Planeshifter Fixed typos. Maybe worth a quick look-over.

@Planeshifter
Copy link
Contributor

Module ready to be updated

@kgryte
Copy link
Contributor Author

kgryte commented Jul 22, 2015

Thanks for reviewing!

kgryte added a commit that referenced this pull request Jul 22, 2015
@kgryte
Merge pull request #2 from compute-io/develop
ee0315a 
Empty data structures, handle non-numerics consistently, and typed-array support.
@kgryte kgryte merged commit ee0315a into master Jul 22, 2015
@kgryte kgryte deleted the develop branch July 22, 2015 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Planeshifter Planeshifter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kgryte @Planeshifter