Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to provide matrix support #1

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

Planeshifter
Copy link
Contributor

refactoring:

  • support matrix input
  • validate.io modules
  • README
  • tests

general update:

  • LICENSE
  • Makefile
  • dotfiles

Open question: Do we need to handle integer typed arrays like Int8Array which do not support NaN separately?

@kgryte
Copy link
Contributor

kgryte commented Jun 11, 2015

Awesome. Thanks for taking the lead on this.

Re: NaN value. So, this gets to the question of whether nan<name> functions should be viewed more as implementations which address the possibility of missing values. If so, then we could go beyond NaN and allow users to provide an option similar to ismissing, which specifies the encoding. In contrast to ismissing, we could make the default check NaN, rather than null.

In essence, the goal with these implementations is provide functions which allow consumers to perform ops directly on their data, rather than filter, create a new data structure, and then run the computation. Your thoughts?

Once we reconcile this, I will more formally review the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants