Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to provide gpg_key directly via chef cookbook file #28

Closed
wants to merge 4 commits into from

Conversation

dwradcliffe
Copy link

We would like to be able to provide the gpg key directly via chef, rather than downloading it from the url. This change allows that. I tried to follow the pattern used in the apt cookbook, but this is much simpler because it only allows the cookbook_file option.

It would be really nice to be able to use the full apt_repository provider under the hood but I do understand that you don't want to have that dependency.

For review: @ice799 @armandocanals @mutemule @JeremyAshton

@ice799
Copy link
Contributor

ice799 commented Oct 9, 2015

Hi:

Thanks for sending this pull request. Definitely open to merging it, two suggestions/comments:

  1. Can you update the docs / add a new section to the docs showing an example?
  2. It would be great to add some sort of kitchen.ci test for this feature. Maybe a test would be adding a repo and then querying the key list with apt-key and checking the key was added?

As far as the APT cookbook dependency goes, yep, we used to depend on that cookbook, but got a few complaints about that dependency so we switched to doing it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants