Allow forcing of os/dist for repository install #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it is very useful to be able to force an specific os platform. This commit enables the end user to force, here a couple examples: ``` packagecloud_repo "computology/packagecloud-cookbook-test-public" do type "deb" force_os "ubuntu" end packagecloud_repo "computology/packagecloud-test-packages" do type "rpm" force_os "rhel" end ``` Idea from sous-chefs#31
afiune
force-pushed
the
afiune/force_os
branch
from
566ff63
to
777f4ea
Compare
added 2 commits
November 20, 2015 21:59
This commit enables the end user to force the os distribution to configure. ``` packagecloud_repo 'computology/packagecloud-cookbook-test-public' do type 'rpm' force_dist '6.5' end ``` Closes sous-chefs#31
afiune
changed the title
|
@capotej Any thoughts on this? 😄 |
|
Looks great! Although I think a I'll merge as soon as our test suite finishes running |
|
@capotej |
|
Oops! Must have missed it :) Merging as soon as tests pass (almost done) |
capotej
added a commit
that referenced
this pull request
Nov 23, 2015
Allow forcing of os/dist for repository install
|
Thanks @afiune! |
|
@capotej Thank you for the review/merge. May I ask when the cookbook could be released to supermarket? 😄 I have to make two more changes and I would love to make them today if possible. Anything I can help with? |
|
Just pushed it up 👍 |
|
That is terrific!!! thank you so much. 😄 |
|
No problem, thanks for the patch! |
afiune
pushed a commit
to afiune/runit
that referenced
this pull request
Nov 24, 2015
The `imeyer/runit` packagecloud repo does not have the ability to resolve packages for OEL systems. By consuming [PR#32](sous-chefs/packagecloud#32) this commit enables `runit` cookbook to be able to install in OEL systems by forcing the os platform to be `rhel` since that is the base and packages should work the same way. Pointing to packagecloud repo (master) in github since there is where the new code for forcing exist. (Need to release it to Supermarket)
afiune
pushed a commit
to afiune/runit
that referenced
this pull request
Nov 24, 2015
The `imeyer/runit` packagecloud repo does not have the ability to resolve packages for OEL systems. By consuming [PR#32](sous-chefs/packagecloud#32) this commit enables `runit` cookbook to be able to install in OEL systems by forcing the os platform to be `rhel` since that is the base and packages should work the same way. Pointing to packagecloud repo (master) in github since there is where the new code for forcing exist. (Need to release it to Supermarket)
afiune
pushed a commit
to afiune/runit
that referenced
this pull request
Nov 30, 2015
The `imeyer/runit` packagecloud repo does not have the ability to resolve packages for OEL systems. By consuming [PR#32](sous-chefs/packagecloud#32) this commit enables `runit` cookbook to be able to install in OEL systems by forcing the os platform to be `rhel` since that is the base and packages should work the same way. Pointing to packagecloud repo (master) in github since there is where the new code for forcing exist. (Need to release it to Supermarket)
afiune
pushed a commit
to afiune/runit
that referenced
this pull request
Mar 1, 2016
The `imeyer/runit` packagecloud repo does not have the ability to resolve packages for OEL systems. By consuming [PR#32](sous-chefs/packagecloud#32) this commit enables `runit` cookbook to be able to install in OEL systems by forcing the os platform to be `rhel` since that is the base and packages should work the same way. Pointing to packagecloud repo (master) in github since there is where the new code for forcing exist. (Need to release it to Supermarket)
chef-delivery
pushed a commit
to chef-boneyard/delivery-cluster
that referenced
this pull request
Mar 3, 2016
There are two PR's that enables Delivery to work with OEL systems, one of them is against packagecloud cookbook and it has already been merged. sous-chefs/packagecloud#32 The other one though is still pending. It is to runit but it is working fine. chef-cookbooks/runit#164 Until we get this merged we will point to this repo that has the improvement. https://github.com/afiune/runit/tree/afiune/make-it-work-in-oel
afiune
pushed a commit
to afiune/runit
that referenced
this pull request
Aug 26, 2016
The `imeyer/runit` packagecloud repo does not have the ability to resolve packages for OEL systems. By consuming [PR#32](sous-chefs/packagecloud#32) this commit enables `runit` cookbook to be able to install in OEL systems by forcing the os platform to be `rhel` since that is the base and packages should work the same way. Pointing to packagecloud repo (master) in github since there is where the new code for forcing exist. (Need to release it to Supermarket)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is very useful to be able to force an specific os platform or even the distribution.
This commit enables the end user to be able to force it, here a couple examples: