Make force_os/force_dist work properly with debian repos #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this merged :) what do we need to get it merged? |
ice799
reviewed
Mar 8, 2017
| force_dist 'wheezy' | ||
| end | ||
|
|
||
| package 'packagecloud-test' |
There was a problem hiding this comment.
this packageline causes the tests to fail
There was a problem hiding this comment.
Oh, I see. I missed your comment on the PR, sorry.
|
So I think perhaps a different test we could add instead of installing a package here would be to check the apt repo config against a regex or something, since that is essentially what we want to verify -- that the repo config was properly written out given a forced OS/dist. |
|
OK, I modified this slightly to use a different test and merged it. Thanks @ctdk for this PR. Closing this out now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in #40 where the force_os/force_dist options don't actually work for deb repos.
One note: in raintank@27080c1#diff-2bb89c3cb0524511e4c762ffc09cf060R21, one can see that the test installs a debian wheezy repo from
computology/packagecloud-test-packagesand installspackagecloud-testfor debian wheezy. Since this does not actually currently exist in that repo it will fail (I had to test with a goiardi repo to make sure it worked, but it didn't seem appropriate for the PR). Someone over there will need to set that up.