Typescript definition is broken (at least for cjs)

[orgads]

import axios from 'axios';
import oauthClient from 'axios-oauth-client';
const axiosInstance = axios.create();
const func = oauthClient(axiosInstance, { url: '' });

const func = (0, axios_oauth_client_1.default)(axiosInstance, { url: '' });
                                              ^
TypeError: (0 , axios_oauth_client_1.default) is not a function
    at Object.<anonymous> (F:\Projects\jstest\dist\tstest.js:6:47)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Module._load (node:internal/modules/cjs/loader:878:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

[compwright]

@orgads this is not a documented use case, you shouldn't rely on calling the default function directly. Instead, call one of the methods demonstrated in the README. There are methods for client credentials, authorization code, owner credentials, and refresh token grants. If there's another you need, I'm happy to add it or better yet submit a PR.

[orgads]

It's the same:

import axios from 'axios'
import oauth from 'axios-oauth-client'
const getAuthorizationCode = oauth.authorizationCode(
  axios.create(),
  'https://oauth.com/2.0/token', // OAuth 2.0 token endpoint
  'CLIENT_ID',
  'CLIENT_SECRET',
  'https://your-app.com/oauth-redirect' // Redirect URL for your app
)

getAuthorizationCode('AUTHORIZATION_CODE');

const getAuthorizationCode = axios_oauth_client_1.default.authorizationCode(axios_1.default.create(), 'https://oauth.com/2.0/token', // OAuth 2.0 token endpoint
                                                          ^

TypeError: Cannot read properties of undefined (reading 'authorizationCode')

[orgads]

Same with 2.0.1. Please reopen.

[compwright]

@orgads can you provide a complete code example that I can run that reproduces your issue? Preferably, a repository that demonstrates the problem. If so I'll be glad to reopen this and fix whatever the problem is. I need more than the code snippet above to be able to see what's going on.

[orgads]

I already did. Try this:

import axios from 'axios'
import oauth from 'axios-oauth-client'
const getAuthorizationCode = oauth.authorizationCode(
  axios.create(),
  'https://oauth.com/2.0/token', // OAuth 2.0 token endpoint
  'CLIENT_ID',
  'CLIENT_SECRET',
  'https://your-app.com/oauth-redirect' // Redirect URL for your app
)

getAuthorizationCode();

[orgads]

Or do you also need package.json and tsconfig.json?

[compwright]

@orgads Yes, I need those too.

[orgads]

package.json:

{
  "name": "jstest",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "keywords": [],
  "author": "",
  "type": "commonjs",
  "license": "ISC",
  "dependencies": {
    "@tsconfig/node18": "^1.0.1",
    "@types/node": "^18.11.11",
    "axios": "^1.2.1",
    "axios-oauth-client": "^2.0.1",
    "typescript": "^4.9.4"
  }
}

tsconfig.json:

{
  "compilerOptions": {
    "target": "es2022",
    "module": "commonjs",
    "skipLibCheck": true
  }
}

[orgads]

Notice that if esModuleInterop is set then it works, but unfortunately I can't use it in my project.

[compwright]

Got it thanks. What command are you running that reproduces the problem?

[orgads]

npx tsc
node test.js

[compwright]

@orgads thanks a lot! Try it now in v2.0.2

[compwright]

@orgads also you will need to change "module": "Node16", in your tsconfig.json.

[orgads]

This also breaks my project. Is there a way to create definitions that are compatible with plain cjs?

[compwright]

Could you elaborate on why you are unable to use "module": "Node16"? It seems a contradiction between "target": "ES2022" and "module": "CommonJS".

[compwright]

This seems to be at the root of the problem: https://www.typescriptlang.org/docs/handbook/2/modules.html#commonjs-and-es-modules-interop

Unless someone can show me a build setting that makes this work, I'm going to just say that if you're using typescript you either need to set "module": "Node16" or enable esModuleInterop. That's not my problem as a library publisher/maintainer, as best as I can determine; it seems to be a Typescript problem.

Again, if you or anyone else can show me how to adjust my Typescript build settings to make this work with your settings, I'm open to making further changes.