Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

integration problems with elm + ko #79

Open
alee opened this issue Jul 4, 2016 · 3 comments
Open

integration problems with elm + ko #79

alee opened this issue Jul 4, 2016 · 3 comments
Assignees

Comments

@alee
Copy link
Member

alee commented Jul 4, 2016

This isn't a huge deal since we'll be completely replacing KO with elm (or react/redux depending on how that experiment works out) but it appears the elm bindings are somehow impacting the way the KO mapping plugin manages its child bindings (analyses + analysis outputs).

The buggy use case for this is running analysis scripts or deleting analysis outputs not updating properly the view. You can see what it should look like on the master branch, and see what is currently happening on the elm branch.

As it stands I won't be deploying the elm branch on production unless this gets fixed, since script running is more central to the project than an improved data group metadata management interface and I don't want to have to refresh the browser constantly during the live demo.

@cpritcha
Copy link
Collaborator

cpritcha commented Jul 5, 2016

When I get rid of the Elm embed in the metadata tab and the include for the elm code deleting analysis outputs still does not update the view. Outputs are also not added once an analysis is completed.

@alee
Copy link
Member Author

alee commented Jul 6, 2016

Strange. Can you verify if it works on master? I wonder if it is a bug
introduced during the merge.

On Tuesday, July 5, 2016, cpritcha notifications@github.com wrote:

When I get rid of the Elm embed in the metadata tab and the include for
the elm code deleting analysis outputs still does not update the view.
Outputs are also not added once an analysis is completed.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#79 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AABYBgFUwy2qmMEGiDAx8F3IHei9IiClks5qSptAgaJpZM4JEqz7
.

Sent from Gmail Mobile

@cpritcha
Copy link
Collaborator

cpritcha commented Jul 6, 2016

On master I cannot get far enough to check that it works right now. See #80. I'm going to try converting the Analysis tab to Elm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants