-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement already installed query for provider yay #140
Conversation
Maybe you have an idea to test this @rawkode ... I can probably mock the Process API and assert on the Steps that are returned from calling For now it's just tested locally on arch. |
with comtrya/comtrya#140 everyting just works without any shenanigans
with comtrya/comtrya#140 everything just works without any shenanigans
908aaf4
to
28b267f
Compare
@mriehl It's really painful to test an I'll look at providing some helpers for this, but for now it's OK. I see that you've tested this with your own dotfiles, soo you're confident and happy it works? |
@mriehl Looks like you need to run |
Resolves comtrya#136 -Qq with package list is chosen for efficiency (no need to query each package individually) There is a bit sad edge case where you can request installation of something like `pkg-config` but the package is actually called `pkgconf` where this will fail to detect already installed. But the "fix" is simply to add the proper package name :) I don't see a way of solving this without shelling out for each package individually or saving all the package aliases.
28b267f
to
ae8d7bc
Compare
Oof. I actually ran
Yup, works perfectly for me, both for AUR and non-AUR packages. I did find out about the issue where it was still installing |
Nevermind, I think it's OK |
Thanks @mriehl ! |
Resolves #136
-Qq with package list is chosen for efficiency (no need to query each
package individually)
There is a bit sad edge case where you can request installation of
something like
pkg-config
but the package is actually calledpkgconf
where this will fail to detect already installed. But the"fix" is simply to add the proper package name :)
I don't see a way of solving this without shelling out for each
package individually or saving all the package aliases.