[feat] variables context #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- variables are added via "Comtrya.yaml":
```yaml
variables:
fkbr: "sxoe"
kuci: "xhpv"
```
which yields
```bash
DEBUG context="variables" key="fkbr" value="sxoe"
DEBUG context="variables" key="kuci" value="xhpv"
```
|
Resolves #10. |
|
Yeah. I rebased on "upstream" and now everything is broken. I fix it |
- sidequest: fix clippy warnings
|
@icepuma Oh, sorry about that - I merged some file.link changes that interfere'd with this. |
|
Already fixed the failing tests and some clippy warnings :) |
rawkode
reviewed
Mar 15, 2022
| assert_eq!(variables_context_values.is_some(), true); | ||
| assert_eq!( | ||
| variables_context_values.unwrap().get("ship_name").unwrap(), | ||
| "Jack O'Neill" |
There was a problem hiding this comment.
I didn't lie when I said that I would clutter the codebase with SG-1 references :D
rawkode
approved these changes
Mar 15, 2022
|
Assuming the tests pass, this is good to go. Great effort, @icepuma |
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 48.15% 52.17% +4.02%
==========================================
Files 46 47 +1
Lines 1838 1748 -90
==========================================
+ Hits 885 912 +27
+ Misses 953 836 -117
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variables are added via "Comtrya.yaml":
which yields