Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nix shell #158

Merged
merged 1 commit into from Mar 21, 2022
Merged

feat: add nix shell #158

merged 1 commit into from Mar 21, 2022

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Mar 21, 2022

No description provided.

@rawkode rawkode requested a review from icepuma March 21, 2022 20:33
@codecov-commenter
Copy link

Codecov Report

Merging #158 (e458d1e) into main (f8ca7f1) will increase coverage by 3.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   48.06%   51.65%   +3.58%     
==========================================
  Files          51       51              
  Lines        1966     1845     -121     
==========================================
+ Hits          945      953       +8     
+ Misses       1021      892     -129     
Impacted Files Coverage Δ
src/actions/directory/mod.rs 0.00% <0.00%> (ø)
src/actions/package/providers/yay.rs 0.00% <0.00%> (ø)
src/actions/package/providers/pkgin.rs 0.00% <0.00%> (ø)
src/actions/package/providers/bsdpkg.rs 0.00% <0.00%> (ø)
src/actions/package/providers/winget.rs 0.00% <0.00%> (ø)
src/actions/package/providers/homebrew.rs 0.00% <0.00%> (ø)
src/contexts/os.rs 96.42% <0.00%> (+0.13%) ⬆️
src/actions/file/copy.rs 14.06% <0.00%> (+0.42%) ⬆️
src/contexts/mod.rs 84.05% <0.00%> (+0.47%) ⬆️
src/actions/file/link.rs 92.92% <0.00%> (+0.92%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ca7f1...e458d1e. Read the comment docs.

Copy link
Member

@icepuma icepuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot say anything about the nix shell. Can you ask someone who is more capable of doing the review?

@rawkode
Copy link
Member Author

rawkode commented Mar 21, 2022

As this doesn't affect Comtrya itself and only provides some build support; I'll merge as is.

@rawkode rawkode merged commit 4999d18 into comtrya:main Mar 21, 2022
@rawkode rawkode deleted the feat/add-nix-shell branch March 21, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants