-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables source configuration #206
Conversation
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 47.65% 46.98% -0.67%
==========================================
Files 64 67 +3
Lines 2044 2088 +44
==========================================
+ Hits 974 981 +7
- Misses 1070 1107 +37
Continue to review full report at Codecov.
|
- multiple values are supported - variables are unique - the last variables source wins - currently supported: - dns+txt://doma.in TXT records via DNS with "KEY=VALUE" content - file+toml:///home/icepuma/file.toml - file+yaml:///home/icepuma/file.yaml
- cargo fmt + clippy + nextest
@rawkode anything you want me to change here or is the feature fine for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change is the public API key in the config, everything else can be modified later.
Feel free to merge, if you're happy with the changes 💪 |
New value in the config (optional):
Supported protocols:
dns+txt://comtrya.icepuma.dev
-> DNS TXT records with content "KEY=VALUE"file+toml:///path/to/file.toml
file+yaml:///path/to/file.yaml
Using an URI makes it easy to extend :)