-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#196][feat] add where condition to manifests #213
Conversation
Codecov Report
@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 46.98% 46.71% -0.27%
==========================================
Files 67 67
Lines 2088 2102 +14
==========================================
+ Hits 981 982 +1
- Misses 1107 1120 +13
Continue to review full report at Codecov.
|
This is a different implementation that we use for actions and I'm wondering if we need them to be comparable? So far, for actions we support a single string and that string can be evaluated with multiples only within that string, such as:
We should make manifests do this, or update actions to be a list too? Or maybe it's not a big deal. I'd like to hear thoughts |
Yeah, @theowenyoung was asking for |
The good thing is, that yaml supports multiline strings and therefore more or less the thing I tried to model with the multiple where conditions |
I changed from multiple conditions to one. Feels better and more consistent. |
- use rhai scripts to use condition - if the rhai script resolves to true -> run manifest - if the rhai script fails or resolves to false -> don't run manifest - context variables can be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the build passes, merge at your own convenience. Great addition.
I'm submitting a
What is the motivation / use case for changing the behavior?
If a manifest runs or not depends on the
dry run
option. Manifest execution can be fine tuned by addingwhere
conditions.