Linux user add #218
Merged
Linux user add #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icepuma
reviewed
Jul 25, 2022
rawkode
requested changes
Jul 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 47.00% 46.45% -0.55%
==========================================
Files 68 69 +1
Lines 2136 2161 +25
==========================================
Hits 1004 1004
- Misses 1132 1157 +25
Continue to review full report at Codecov.
|
|
A comment for the review. I use compiler directives for Linux and non-Linux since keeping it all in a match body to match against os_info Types would be exhaustive and need to be kept up to date as os_info add more distros to it's types. |
rawkode
approved these changes
Jul 26, 2022
icepuma
reviewed
Jul 26, 2022
| @@ -6,6 +6,8 @@ use self::none::NoneUserProvider; | |||
| use super::UserVariant; | |||
| use schemars::JsonSchema; | |||
| use serde::{Deserialize, Serialize}; | |||
| mod linux; | |||
| use self::linux::LinuxUserProvider; | |||
|
|
|||
| #[derive(JsonSchema, Clone, Debug, Serialize, Deserialize)] | |||
| pub enum UserProviders { | |||
There was a problem hiding this comment.
A minor nit. You could get rid of ...UserProvider. I think, that's why clippy is complaining.
But you can merge if you solve it later 👍
icepuma
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a
What is the current behaviour?
Comtrya uses the NoneProvider on linux distibutions.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
Be able to use the user add action to add users to a linux system
What is the motivation / use case for changing the behavior?
Feature parity with FreeBSD on Comtrya and useful feature for all supported operating systems for Comtrya
Please tell us about your environment:
OpenSUSE TumbleWeed
Version (
comtrya --version): comtrya 0.7.4Operating system:
OpenSUSE Tumbleweed