Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] macOS build (deprecation) #225

Merged
merged 1 commit into from Jul 27, 2022
Merged

[fix] macOS build (deprecation) #225

merged 1 commit into from Jul 27, 2022

Conversation

icepuma
Copy link
Member

@icepuma icepuma commented Jul 27, 2022

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

macOS build fails due to deprecation

@icepuma icepuma requested review from a team, rawkode and martintc and removed request for a team July 27, 2022 09:44
@icepuma
Copy link
Member Author

icepuma commented Jul 27, 2022

As I am not using macOS I was wondering if you guys also want to have macOS 12 aarch64-apple-darwin (Silicon) as well in the main.yaml build matrix.

@rawkode
Copy link
Member

rawkode commented Jul 27, 2022

Yeah, lets add 12!

@icepuma
Copy link
Member Author

icepuma commented Jul 27, 2022

x86 and Silicon, so that we have macOS 11 (Silicon + x86) and macOS 12 (Silicon + x86)?

@rawkode
Copy link
Member

rawkode commented Jul 27, 2022

Sounds good

- actions/runner-images#5583
- sidequest:
  - add macOS 12 build as well
@icepuma icepuma merged commit 9a76bca into comtrya:main Jul 27, 2022
@icepuma icepuma deleted the macos_build branch July 27, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants