Context enum #234
Merged
Context enum #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 44.64% 46.26% +1.62%
==========================================
Files 70 71 +1
Lines 2249 2475 +226
==========================================
+ Hits 1004 1145 +141
- Misses 1245 1330 +85
Continue to review full report at Codecov.
|
- supports:
- Null
- String
- Number
- Unsigned (u64)
- Signed (i64)
- Float (f64)
- List of Values
- A lot of the ideas come from https://github.com/dtolnay/serde-yaml/tree/master/src
- There is a lot to do till we support more value types and more From
implementations for different numbers, but it's good enough for now.
icepuma
requested review from
a team,
rawkode and
martintc
and removed request for
a team
martintc
approved these changes
Jul 30, 2022
|
@rawkode anything to add or can I merge? |
rawkode
approved these changes
Aug 1, 2022
|
That's what I intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a
What is the current behaviour?
We use the
Valuestruct fromserde_yamlwhich is tied to their crate.If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
We want to have an own implementation of a
Valueclass which does not depend on any external crate.What is the motivation / use case for changing the behavior?
Be more independent from outside development
Please tell us about your environment: