Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add more descriptive error message to file resolution #241

Merged

Conversation

andrew-welker
Copy link
Contributor

@andrew-welker andrew-welker commented Aug 7, 2022

I'm submitting a

  • bug fix
  • feature
  • [ x] documentation addition

What is the current behaviour?

When a file is not found or file resolution fails due to some other error, the error message received is not very descriptive of what file caused the problem. See #198 for an example of the error. Closes #199 .

What is the expected behavior?

The error message should assist the user in solving the problem by displaying what path caused the issue and what manifest the file was pulled from.

What is the motivation / use case for changing the behavior?

To provide a better UX when/if something goes wrong.

Please tell us about your environment:

Operating system: Windows 11, WSL2 running Ubuntu 20.04

@codecov-commenter
Copy link

Codecov Report

Merging #241 (32e60f5) into main (d15f746) will decrease coverage by 0.06%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   45.72%   45.65%   -0.07%     
==========================================
  Files          72       72              
  Lines        2504     2510       +6     
==========================================
+ Hits         1145     1146       +1     
- Misses       1359     1364       +5     
Impacted Files Coverage Δ
lib/src/actions/file/mod.rs 33.33% <16.66%> (-6.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martintc martintc merged commit 8ce6e12 into comtrya:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve File Not Found Error Message
4 participants