Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code for adding users to groups upon creation #253

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

martintc
Copy link
Contributor

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

No way to add users to groups.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

The ability to add users to group during the user creation step.

What is the motivation / use case for changing the behavior?

Better configuration management for users

Please tell us about your environment:

Version (comtrya --version): Main branch on repo
Operating system: Fedora 36

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 44.81% // Head: 47.51% // Increases project coverage by +2.69% 🎉

Coverage data is based on head (849963b) compared to base (53a48ab).
Patch coverage: 80.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   44.81%   47.51%   +2.69%     
==========================================
  Files          77       77              
  Lines        2557     2635      +78     
==========================================
+ Hits         1146     1252     +106     
+ Misses       1411     1383      -28     
Impacted Files Coverage Δ
lib/src/actions/user/mod.rs 0.00% <0.00%> (ø)
lib/src/actions/user/providers/freebsd.rs 0.00% <0.00%> (ø)
lib/src/actions/user/providers/mod.rs 28.57% <ø> (+28.57%) ⬆️
lib/src/actions/user/providers/none.rs 0.00% <0.00%> (ø)
lib/src/actions/user/providers/linux.rs 90.90% <89.47%> (+90.90%) ⬆️
lib/src/actions/group/providers/linux.rs 91.66% <100.00%> (+91.66%) ⬆️
lib/src/actions/group/providers/mod.rs 33.33% <0.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martintc martintc marked this pull request as ready for review September 20, 2022 02:37
@martintc martintc requested review from rawkode, a team and icepuma and removed request for a team September 20, 2022 16:12
Copy link
Member

@icepuma icepuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martintc martintc merged commit 41432a5 into comtrya:main Sep 28, 2022
@martintc martintc deleted the user-group branch October 28, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants