Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adding users to groups outside of user creation #255

Merged
merged 2 commits into from Oct 19, 2022

Conversation

martintc
Copy link
Contributor

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Adding users to groups currently has to happen during the user creation step.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

Exposes an action a user can use to add a user to a group outside of the user creation step.

What is the motivation / use case for changing the behavior?

Allow for improved user management

Please tell us about your environment:

Version (comtrya --version): Dev
Operating system: Fedora 36

@martintc martintc requested review from a team, rawkode and icepuma and removed request for a team September 29, 2022 04:16
@codecov-commenter
Copy link

Codecov Report

Base: 47.51% // Head: 47.37% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (0887ee3) compared to base (41432a5).
Patch coverage: 37.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   47.51%   47.37%   -0.15%     
==========================================
  Files          77       78       +1     
  Lines        2635     2643       +8     
==========================================
  Hits         1252     1252              
- Misses       1383     1391       +8     
Impacted Files Coverage Δ
lib/src/actions/mod.rs 19.71% <0.00%> (-0.58%) ⬇️
lib/src/actions/user/add_group.rs 0.00% <0.00%> (ø)
lib/src/actions/user/mod.rs 0.00% <ø> (ø)
lib/src/actions/user/providers/freebsd.rs 0.00% <0.00%> (ø)
lib/src/actions/user/providers/mod.rs 28.57% <ø> (ø)
lib/src/actions/user/providers/none.rs 0.00% <0.00%> (ø)
lib/src/actions/user/providers/linux.rs 90.90% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martintc martintc merged commit 71d2fb9 into comtrya:main Oct 19, 2022
@martintc martintc deleted the linux-user-group branch October 28, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants