Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure all actions in a manifest run #270

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Nov 16, 2022

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

Comtrya stops as soon as an action returns an empty plan, meaning no further actions run.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version (comtrya --version):
Operating system:

@codecov-commenter
Copy link

Codecov Report

Base: 46.70% // Head: 46.70% // No change to project coverage 👍

Coverage data is based on head (325b969) compared to base (d63d468).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   46.70%   46.70%           
=======================================
  Files          79       79           
  Lines        2689     2689           
=======================================
  Hits         1256     1256           
  Misses       1433     1433           
Impacted Files Coverage Δ
app/src/commands/apply.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rawkode rawkode merged commit 54095b3 into main Nov 16, 2022
@rawkode rawkode deleted the fix/actions-skipped-on-first-empty-plan branch November 16, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants