.unwrap() #284
Merged
.unwrap() #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some calls are unavoidable and are marked with comments - some calls were replaced with .expect to panic where it is okay-ish
|
@comtrya/maintainers it would be cool if you both have time to review this PR. Please be extra careful, because I changed a lot of things here. Thanks a lot in advance! |
icepuma
requested review from
a team,
rawkode and
martintc
and removed request for
a team
martintc
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a
What is the motivation / use case for changing the behavior?
Be a bit more aware of the code and handle
OptionandResulta bit better.