Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows doesn't have "ls" on the path so make a test for windows that… #291

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

martintc
Copy link
Contributor

… tests for a command in the path

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

it_returns_true_when_found test fails

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

The test passes

What is the motivation / use case for changing the behavior?

All tests should pass. The current tests looks for "ls" which isn't on window's path as an executable. This create a conditional compilation for the test such that the test that looks for "ls" is used on unix/unixy systems and there is a similar test compile for windows.

Please tell us about your environment:

Version (comtrya --version): 0.8.0
Operating system: Windows 11

@martintc martintc requested review from a team, rawkode and icepuma and removed request for a team December 17, 2022 08:08
@codecov-commenter
Copy link

Codecov Report

Base: 46.64% // Head: 46.64% // No change to project coverage 👍

Coverage data is based on head (2badaf8) compared to base (7e6eace).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   46.64%   46.64%           
=======================================
  Files          79       79           
  Lines        2742     2742           
=======================================
  Hits         1279     1279           
  Misses       1463     1463           
Impacted Files Coverage Δ
lib/src/steps/initializers/command_found.rs 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martintc martintc merged commit abc9758 into comtrya:main Dec 18, 2022
@martintc martintc deleted the windows-fix-commandfound-test branch December 29, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants