Windows directory copy #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests for a command in the path
martintc
requested review from
a team,
rawkode and
icepuma
and removed request for
a team
Codecov ReportBase: 46.64% // Head: 46.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 46.64% 46.64%
=======================================
Files 79 79
Lines 2742 2742
=======================================
Hits 1279 1279
Misses 1463 1463
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
icepuma
reviewed
Dec 18, 2022
| @@ -23,6 +23,17 @@ mod tests { | |||
| assert_eq!(false, result.unwrap()); | |||
| } | |||
|
|
|||
| #[cfg(target_family = "windows")] | |||
| #[test] | |||
| fn it_returns_true_when_found() { | |||
There was a problem hiding this comment.
Optional: Can't we add a useful xcopy test here?
icepuma
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a
What is the current behaviour?
Directories fail to copy on windows
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
Run a directory copy manifest on windows
#275
What is the expected behavior?
Be able to have a manifest copy a directory
What is the motivation / use case for changing the behavior?
Fix broken functionality
Please tell us about your environment:
Version (
comtrya --version): 0.8.0Operating system: Windows 11