Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure failed where clause doesn't stop exeuction #296

Merged
merged 1 commit into from Dec 24, 2022

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Dec 24, 2022

Fixes #279

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version (comtrya --version):
Operating system:

@rawkode rawkode requested review from a team, icepuma and martintc and removed request for a team December 24, 2022 00:31
@codecov-commenter
Copy link

Codecov Report

Base: 46.45% // Head: 46.45% // No change to project coverage 👍

Coverage data is based on head (078e17f) compared to base (f07de22).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   46.45%   46.45%           
=======================================
  Files          79       79           
  Lines        2753     2753           
=======================================
  Hits         1279     1279           
  Misses       1474     1474           
Impacted Files Coverage Δ
app/src/commands/apply.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rawkode rawkode merged commit bc73acb into main Dec 24, 2022
@rawkode rawkode deleted the fix/ensure-failed-where-continues branch December 24, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: manifest with action containing a where statement prevents all further actions from running
3 participants