Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix aarch64 linux binaries #357

Merged
merged 15 commits into from Nov 8, 2023

Conversation

martintc
Copy link
Contributor

@martintc martintc commented Nov 5, 2023

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Binaries for aarch64-unknown-linux-gnu are not compiled correctly in the artifacts.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

aarch64-unknown-linux-gnu binary is an actual aarch64 binary

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version (comtrya --version):
Operating system:

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f394479) 28.59% compared to head (98180d9) 28.59%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   28.59%   28.59%           
=======================================
  Files          84       84           
  Lines        2263     2263           
=======================================
  Hits          647      647           
  Misses       1616     1616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintc martintc changed the title attempt to fix aarch64 linux binaries fix: attempt to fix aarch64 linux binaries Nov 7, 2023
@martintc martintc merged commit 2fa4278 into comtrya:main Nov 8, 2023
4 checks passed
martintc added a commit to martintc/comtrya that referenced this pull request Nov 8, 2023
martintc added a commit that referenced this pull request Nov 8, 2023
@martintc martintc deleted the fix-aarch64-binaries branch December 29, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants