Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #114

Closed
rubensworks opened this issue Mar 14, 2018 · 6 comments
Closed

Logging #114

rubensworks opened this issue Mar 14, 2018 · 6 comments
Assignees

Comments

@rubensworks
Copy link
Member

We should support logging like in the old ldf-client, for logging things like the executed HTTP requests. This is required for comunica/jQuery-Widget.js#2.

Potentially related to #109.

@rubensworks
Copy link
Member Author

While the comunica prototype initially uses a winston logger, it felt too limited, so I suggest not using it again.

I think a more configurable logging framework (like log4js) would be ideal, as it supports different logging levels and categories.

One thing to keep in mind is performance. So we might want to scope logging calls behind certain flags.

@rubensworks
Copy link
Member Author

This might be a good lib we can use: https://github.com/guigrpa/storyboard

@rubensworks
Copy link
Member Author

Depends on #109.

@rubensworks rubensworks removed this from To Do in Development Major Jun 13, 2018
@rubensworks rubensworks added this to To do in Development 1.2.0 via automation Jun 13, 2018
@rubensworks
Copy link
Member Author

Two types of logging are needed: Intra and inter-actor logging.

@rubensworks
Copy link
Member Author

As of #183, contexts are now passed along all IAction's, so this can be implemented with this.

@rubensworks
Copy link
Member Author

Bunyan seems to be good and flexible enough for our case, and there also exists an isomorphic version (https://www.npmjs.com/package/iso-bunyan-stream).

#204 has to be fixed before this can be implemented, as the initialize methods seems to be the best way to pass around logger instances. (I want to avoid static solutions)

@rubensworks rubensworks self-assigned this Aug 13, 2018
@rubensworks rubensworks moved this from To do to In progress in Development 1.2.0 Aug 13, 2018
Development 1.2.0 automation moved this from In progress to Done Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant