Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid .bin files from repo packages #122

Closed
joachimvh opened this issue Mar 26, 2018 · 3 comments
Closed

Invalid .bin files from repo packages #122

joachimvh opened this issue Mar 26, 2018 · 3 comments
Assignees
Projects

Comments

@joachimvh
Copy link
Member

Issue type:

Only keep the issue types that are applicable.

  • 馃悰 Bug

Description:

The generated .bin files of other packages in the monorep seem te be unusable.
E.g. .bin/comunica-run looks as follows:

"$basedir/../../../runner-cli/bin/run.js"   "$@"
exit $?

while a normal generated .bin file looks something like this:

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/../acorn/bin/acorn" "$@"
  ret=$?
else 
  node  "$basedir/../acorn/bin/acorn" "$@"
  ret=$?
fi
exit $ret

Might be a Lerna thing, but it causes me to be unable to use those .bin files.


Environment:

Exact versions of the software in your environment, not just latest. Only needed for 馃悰 and 馃悓.

software version(s)
Comunica Init Actor @comunica/actor-init-hello-world 1.0.0
Comunica 1.0.0
node 8.4.0
npm 5.7.1
Operating System Windows
@joachimvh joachimvh added this to To Do in Development 1.0.0 via automation Mar 26, 2018
@rubensworks
Copy link
Member

Not sure if I'll be able to help with that, probably a Windows-only issue, as my bins are just symlinks.

@joachimvh
Copy link
Member Author

I found out about it because Arne had problems with the bin stuff, so I assumed there's also a problem on Unix. Also, symlinking to the file is different behaviour from what the bin files are supposed to do. As you can see in the example above, that bin file actually calls node FILE_NAME_HERE instead of just calling the file as a command.

Also this is totally low priority, this issue is mostly here so we can remember it when the problem pops up :P

@rubensworks rubensworks added this to To Do in Maintenance via automation Apr 9, 2018
@rubensworks rubensworks removed this from To Do in Development 1.0.0 Apr 9, 2018
@joachimvh
Copy link
Member Author

joachimvh commented May 31, 2018

Update: this is apparently only a problem with comunica-run, all the other .bin files are fine

Maintenance automation moved this from To Do to Done Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Maintenance
  
Done
Development

No branches or pull requests

2 participants