-
Notifications
You must be signed in to change notification settings - Fork 7
Clean up tests #34
Comments
I was looking at this issue and I wonder whether you could provide some more information on the tasks you mentioned. |
I think it's a bit of both, testAll+testAllErrors is a bit more straightforward (in implementation and use) then the TruthThable, it doesn't require the aliasing maps, and doesn't hide the operator. The cases in testAll(Errors) are simply correct expressions, while the Truthtable is more like a parametrized expression. It think it's sensible to have both, but this difference is not very clear from naming. documentation, and API. If you can abstract this decently, I'm definitely not opposed to it, e.g. with naming In regards to the points in the issues:
where |
Thank you for the clarification! I will consider |
I would suggest keeping everything dist-related in
|
I explained myself badly, this was what I meant, but then:
with lib instead of unit (but I have no preference, although they're not really unit tests, they go end-to-end much like an integration test) |
Ah, no unit tests indeed (but we'll probably need them later for achieving full coverage)
Perhaps we can just call it So that would then become:
|
All fine by me. |
It might be that this inconsistency is solved by using |
Very likely yes. Anyway, if we don't know what it means by now, we can close it. |
The text was updated successfully, but these errors were encountered: