Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Feature/add experimental mode #117

Merged

Conversation

jitsedesmet
Copy link
Member

This pull request aims to provide a flag that enables the new type system. This new type system is needed to use some type promotion and type substitution. It is also essential to enable the flag when using getSuperType. The new type system is more powerful and more spec complaint. It is yet somewhat slower than what we had. This can be seen in this comment #112 (comment). This flag makes the use of the new type system opt-in. It would be nice if we found a way to optimize the new system so we could make the new type system default.

@coveralls
Copy link

coveralls commented Aug 27, 2021

Coverage Status

Coverage decreased (-1.2%) to 89.341% when pulling 48db18b on jitsedesmet:feature/add-experimental-mode into fa38d50 on comunica:master.

Copy link
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments.

Before we merge, be sure to check everything in Comunica as well.

benchmarks/integerAddition.ts Outdated Show resolved Hide resolved
lib/evaluators/evaluatorHelpers/BaseExpressionEvaluator.ts Outdated Show resolved Hide resolved
@rubensworks rubensworks merged commit 51aa287 into comunica:master Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants