-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Symfony3 #64
Comments
I also looked into upgrading to Sym3.0 and this issue of deprecated code came from the check-list for upgrade. Profiler shows this message: I looked around and found that this should be an easy fix. I think the deprecated message comes from Twig extension class: /vendor/comur/image-bundle/Comur/ImageBundle/Twig/ThumbExtension.php Line #4: Change to: And /vendor/comur/image-bundle/Comur/ImageBundle/Resources/config/routing.yml syntax needs to change "pattern: " to "path: ". I hope it's an only thing that needs to be done for this bundle to be Sym3.0 compliant. |
Hi, |
@comur I never done major version upgrade for Symfony, so i'm still in process resolving all of my own code before getting it to work and some 3rd party bundles which are also pending update. But i'll write when i get it to work and i'll let you know the results. |
Hi,
I'll try to fork project and correct these calls. |
I just created a pull request for compatibility : #65 Thanks. |
@anthonyherve oooh, nice work dude. thumbs up |
@anthonyherve thanks for this work ! Thanks again, i will try to look ASAP and merge it. |
I'm checking it on a SF3 project, but I have a little problem with version of jms/translation-bundle. The last stable version of this bundle is not compliant with SF3. So I put dev-master, but I have following problem : Have you already saw this problem ? |
@comur I'll try to find time to start fresh AWS instance and maybe do a clean Symfony 3.0 install and add your bundle + anthonys changes from the fork. I cant get composer through update with Symfony 3.0, as mentioned above there is a whole load of 3rd party bundles which are not up to date. Our main server still runs on PHP 5.4.x, i cant even test on it. @anthonyherve Do you have translation bundle enabled inside Dev? I think this causes it:
Source: schmittjoh/JMSTranslationBundle#169 Also PHP version constraint in composer... I think that expression ::class, for resolving class names has only been added in PHP 5.5, my NetBeans pointed that out. Source: http://php.net/manual/en/migration55.new-features.php |
OK i have a AWS instance with clean PHP 5.7 and Symfony 3.0, i can just do a basic tests. I dont mean sound stupid, but doing composer update won't work, since anothony's code is in separate bundle. I there i fancier way than just grabbing a zipball of his fork and dropping it in? |
Cool news ! Good luck ! I'm waiting for your answer. :-) |
We have to add "prefer-stable" : true in composer.json to avoid downloading all dev versions of dependencies. Thanks. |
Hi, i will create a new branch for compatibility with SF3. |
I tried to regenerate with command, but I have errors with JMSTranslationBundle. Can you try it on your side with branch symfony3 of my fork ? |
@anthonyherve Does this run successfully? *bin/console translation:update en ComurImageBundle --force --output-format xlf * This Symfony 3 is a major pain in the butt, i cant even partially transfer our dev site to Symfony 3. I think i just code fresh controller, Entity and fresh Symfony form to test this. I can't get anything to work, 'cause one 3rd party bundle catches on other and they all have non-compatible dependencies. I mean i added your fork on clean Sym3 install, and initial page comes up fine, clearing cache works. Services are included and no red flags coming up.
Composer lock file shows that ComurImageBundle is from local git (your cloned fork), so it at least installs and Symfony 3 is running.
Just to verify the GIT is actually your fork:
Profiler shows ComurBundle enabled and working. Assets are getting installed too:
So i don't know, seems ok. To be honest i'd love to test it by ACTUALLY using it with Entities and Forms, but can't find a free night to code a basic fresh code using it. |
Anyone got this bundle working with symfony3? |
Hi @joskewie |
aha thanks! checked the wrong readme indeed, works now |
There's still a bug at https://github.com/comur/ComurImageBundle/blob/1.3/Form/Type/CroppableImageType.php line 44. |
Please check with last release |
No description provided.
The text was updated successfully, but these errors were encountered: