Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on dev/master of jms/translation-bundle #104

Closed
thelem opened this issue May 31, 2017 · 1 comment
Closed

Remove dependency on dev/master of jms/translation-bundle #104

thelem opened this issue May 31, 2017 · 1 comment

Comments

@thelem
Copy link
Contributor

thelem commented May 31, 2017

#64 made us depend on dev/master of jms/translation-bundle, as at the time there were no releases that were compatible with Symfony 3.

Since then, 1.2.2 has been released, including Symfony 3 support, see https://github.com/schmittjoh/JMSTranslationBundle/releases

We should therefore change the minimum version to requirement to 1.2.2.
@thelem
Copy link
Contributor Author

thelem commented May 31, 2017

Opened #105 to fix this

comur added a commit that referenced this issue Sep 14, 2017
@comur
Merge pull request #105 from thelem/thelem-patch-1
2942911 
Require jms/translation-bundle ^1.2.2 (Fixes #104)
@comur comur closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thelem @comur